Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show only folder create action in embed mode #9853

Merged
merged 1 commit into from
Oct 26, 2023
Merged

feat: show only folder create action in embed mode #9853

merged 1 commit into from
Oct 26, 2023

Conversation

LukasHirt
Copy link
Collaborator

Description

Hide the create and upload actions in embed mode and provide a single create folder button instead.

Related Issue

Motivation and Context

Since the embed mode provides only create folder action, it does not make sense to hide this in a dropdown.

How Has This Been Tested?

  • test environment: local
  • test case 1: open web in embed mode and see the correct action being displayed
  • test case 2: open web in default mode and see the original actions still present

Screenshots (if appropriate):

localhost_9200__mode=embed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Oct 24, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@LukasHirt LukasHirt force-pushed the feat/embed-folder-creation branch from 28a05c8 to 153a15e Compare October 24, 2023 10:57
@LukasHirt LukasHirt marked this pull request as ready for review October 24, 2023 10:57
@LukasHirt
Copy link
Collaborator Author

@JammingBen @dschmidt ping for review 🙏

@LukasHirt LukasHirt force-pushed the feat/embed-folder-creation branch from 153a15e to 912d42f Compare October 25, 2023 12:09
@CLAassistant
Copy link

CLAassistant commented Oct 25, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@LukasHirt LukasHirt force-pushed the feat/embed-folder-creation branch from 912d42f to a7c3c4a Compare October 25, 2023 12:10
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@LukasHirt LukasHirt mentioned this pull request Oct 25, 2023
Merged
9 tasks
@JammingBen JammingBen merged commit 9cb8309 into owncloud:master Oct 26, 2023
2 checks passed
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LukasHirt @CLAassistant @JammingBen